Bug #1157

Rex::Services::LocalRelay seems broken after r8753

Added by Stephen Fewer almost 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:03/16/2010
Priority:Normal Due date:
Assignee:Stephen Fewer % Done:

0%
Category:general
Target version:Metasploit 3.4.0
Resolution:worksforme Release Note:

Description

Seems like r8753 (one liner switch from 'select' to '::Kernel.select') has introduced issues in Rex::Services::LocalRelay (the relay wont stream to the viewer in the vnc payload for example) and possibly other places.

Anybody know if it is safe to revert r8753? or what issue r8753 was meant to fix as it may be related to whatever has broken in the LocalRelay.

(I'm using 'ruby 1.9.1p243 (2009-07-16 revision 24175) [i386-mingw32]' as this could be a weird interpreter issue)

History

#1
Updated by Stephen Fewer almost 2 years ago

  • Assignee changed from James Lee to Stephen Fewer

...I can take the ticket though.

#2
Updated by HD Moore almost 2 years ago

Let me double check, I swear there was a reason for it

#3
Updated by HD Moore almost 2 years ago

This select should have no impact on the LocalRelay code - its just a sleep() call and lives inside of a standalone thread used to check whether a session is still alive. The reason for the change is select() would call the wrong method - we are just trying to sleep for half a second. If this is breaking LocalRelay, it could be due to the keepalive check itself.

#4
Updated by Stephen Fewer almost 2 years ago

Ok thanks. Reverting it on my local tree got the relay working again which is why I though it was somehow related. Ill dig further and see what I can turn up, thanks.

#5
Updated by HD Moore almost 2 years ago

I am not seeing the problem anymore, VNC is relaying fine, can you reproduce still?

#6
Updated by HD Moore almost 2 years ago

  • Target version set to Metasploit 3.4.0

#7
Updated by Stephen Fewer almost 2 years ago

  • Status changed from New to Closed
  • Resolution set to worksforme

Just rechecked and can't reproduce so closing the ticket (will keep an eye on things and reopen if I come across it again).

Also available in: Atom PDF